Bug 47 – Off by one bug in assigning script buffer and heap wastes memory

Bug 47 - Off by one bug in assigning script buffer and heap wastes memory

Summary:

Off by one bug in assigning script buffer and heap wastes memory

Status:	RESOLVED FIXED

Product:	OHRRPGCE
Component:	Plotscripts
Version:	unknown
Platform:	Other other

Importance:	P3 normal (vote)
Assigned To:	Ralph Versteegen

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-03-05 02:19 PST by Ralph Versteegen
Modified:	2005-03-05 20:00 PST (History)
CC List:	1 user (show)

See Also:

Attachments
Patch to fix off by one errors in Runscript (1.01 KB, patch) 2005-03-05 02:20 PST, Ralph Versteegen	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ralph Versteegen 2005-03-05 02:19:11 PST

When a script is run, it is assigned script buffer and heap one int ahead of
where it should be.

Additionally, if either the buffer or heap is filled exactly, an overflow is
triggered, even though the script fis completely

Comment 1 Ralph Versteegen 2005-03-05 02:20:59 PST

Created attachment 9 [details]
Patch to fix off by one errors in Runscript

I wasted too much time testing this one :/

Comment 2 Bob the Hamster 2005-03-05 20:00:25 PST

Ooh! Thanks for noticing that. Good catch.
I have applied the patch.
Matking fixed. We can verify after quaternion.